Skip to content

Migrate to element2 APIs #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2025
Merged

Migrate to element2 APIs #1504

merged 5 commits into from
Jul 10, 2025

Conversation

davidmorgan
Copy link
Collaborator

@davidmorgan davidmorgan commented Jun 25, 2025

Let's land element2, hurrah :)

@davidmorgan davidmorgan force-pushed the element2 branch 3 times, most recently from cc31908 to 8e4d986 Compare June 26, 2025 08:40
@kevmoo
Copy link
Collaborator

kevmoo commented Jun 26, 2025

analyze still sad 😢

@davidmorgan
Copy link
Collaborator Author

analyze still sad 😢

That was about pubspecs again ... updated to use the now-published source_gen 3.0.0-dev.

Updated with refs for source_gen_test and source_helper, once these are published I can update again and take a look at the failing pubspec-related tests. I guess, when back from vacation :) feel free to take it over if you particularly want to ;) but for builders we don't actually need to publish prerelease versions, just check everything works ready for the full releases.

Thanks :)

@kevmoo
Copy link
Collaborator

kevmoo commented Jun 27, 2025

I will see if I can help here.

@kevmoo
Copy link
Collaborator

kevmoo commented Jun 27, 2025

I need to update source_helper

@kevmoo
Copy link
Collaborator

kevmoo commented Jul 2, 2025

you might want to rebase!

@davidmorgan davidmorgan marked this pull request as ready for review July 10, 2025 07:31
@davidmorgan
Copy link
Collaborator Author

@kevmoo this looks ready now, could you please review? :)

freezed depends on json_serializable, so I think it's probably worth publishing this dev version, even though it will only be for the benefit of a few people :)

@kevmoo kevmoo merged commit bc8fcb9 into google:master Jul 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants